Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--except is ignored during hosting deployment #3397

Closed
maxprilutskiy opened this issue May 24, 2021 · 2 comments · Fixed by #3593
Closed

--except is ignored during hosting deployment #3397

maxprilutskiy opened this issue May 24, 2021 · 2 comments · Fixed by #3593
Assignees
@bkendall
Labels
api: hosting

Comments

@maxprilutskiy
Copy link

maxprilutskiy commented May 24, 2021 •
edited

Environment info

firebase-tools: 9.11.0

Platform: macOS

Test case

Hi all,
firebase deploy --only hosting:@my-project/my-app works as expected, however firebase deploy --except hosting:@my-project/my-app does not. Instead, it ignores the --except and deploys all the websites.

As a temporary workaround I'm doing the following:

yarn firebase deploy --except hosting
yarn firebase deploy --only hosting:@my-project/my-app1,hosting:@my-project/my-app2

but it's too verbose and unnecessary complex.
@google-oss-bot
Copy link
Contributor

This issue does not seem to follow the issue template. Make sure you provide all the required information.

bkendall added a commit that referenced this issue Jul 21, 2021
@bkendall
adds filterExcept to normalizedHostingConfigs
f0efe24 
fixes #3397
bkendall added a commit that referenced this issue Jul 21, 2021
@bkendall
adds filterExcept to normalizedHostingConfigs
c2f71fa 
fixes #3397
@bkendall bkendall mentioned this issue Jul 21, 2021
Merged
@bkendall bkendall self-assigned this Jul 21, 2021
@bkendall
Copy link
Contributor

Sorry to only get around to this now, but you're right - I can still reproduce this. I have a PR out now to fix it! :)

bkendall added a commit that referenced this issue Jul 23, 2021
@bkendall
adds filterExcept to normalizedHostingConfigs (#3593)
b5b6e5f 
* adds filterExcept to normalizedHostingConfigs

fixes #3397

* remove .only

* add changelog

* pass only'd configs to except

* one clarifying comment

* rename and cleanup
devpeerapong pushed a commit to devpeerapong/firebase-tools that referenced this issue Dec 14, 2021
@bkendall @devpeerapong
adds filterExcept to normalizedHostingConfigs (firebase#3593)
0d8ae6f 
* adds filterExcept to normalizedHostingConfigs

fixes firebase#3397

* remove .only

* add changelog

* pass only'd configs to except

* one clarifying comment

* rename and cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkendall bkendall

Labels
api: hosting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds filterExcept to normalizedHostingConfigs firebase/firebase-tools
3 participants
@bkendall @maxprilutskiy @google-oss-bot