Fix auth_time in Auth Emulator. #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
force-pushed
the
ys/fix-auth-time
branch
from
812eff0
to
8b310ea
Compare
yuchenshi
force-pushed
the
ys/fix-auth-time
branch
from
0510d46
to
f5f44a2
Compare
sam-gc
approved these changes
Aug 13, 2021
| @@ -1755,6 +1750,27 @@ function generateJwt( | |||
| return jwtStr; | |||
| } | |||
|
|
|||
| function getAuthTime(user: UserInfo): Date { | |||
| if (user.lastLoginAt != null) { | |||
There was a problem hiding this comment.
This is intentional since it can be undefined. TS won't let me do !== null
| throw new Error(`Internal assertion error: invalid user.lastLoginAt = ${user.lastLoginAt}`); | ||
| } | ||
| return authTime; | ||
| } else if (user.lastRefreshAt != null) { |
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Aug 13, 2021
mikehardy
added a commit
to invertase/react-native-firebase
that referenced
this pull request
Aug 13, 2021
devpeerapong
pushed a commit
to devpeerapong/firebase-tools
that referenced
this pull request
Dec 14, 2021
* Fix auth_time in Auth Emulator. * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3671.
Fixes #3663.
Fixes #3673.
Date parsing is hard. This was broken in #3611. I've added comments and assertions for the details.
Scenarios Tested
Tests added in #3611 was also wrong and I've fixed that as well. Again, date parsing is hard.
Sample Commands
N/A