Fix bug where ESM module load fails on windows.

[taeold]

Patch allows Windows users to deploy Firebase Functions packaged as ES module.

We apply the same fix we made for Windows ES module support in the Functions Emulator (#3574) to the triggerParser script.

Fixes #3689

[joehan]

One phrasing nit in CHANGELOG

[ghost]

Is writing them as ESM explained in docs?

[taeold]

@web2033 Nothing yet for Firebase Functions, but here's an article for Google Cloud Functions https://medium.com/google-cloud/es-modules-in-cloud-functions-f5be1676c8b5.

[ZYinMD]

Do I need to add "@google-cloud/functions-framework": "^1.9.0" explicitly?

[fouchekeagan]

@web2033 I will write a Medium article for Firebase Functions on Node 14 with ESM Modules within the next week.

[taeold]

@ZYinMD I don't think you have to anymore https://github.com/GoogleCloudPlatform/buildpacks/blob/81eea2ebeff19c22e77c072ff7494c3d9d29b78b/cmd/nodejs/functions_framework/converter/without-framework/package.json#L4

[ZYinMD]

@fouchekeagan When writing your a blog, you might want to see this: microsoft/vscode#131837. I'd like to see how you set up your per-folder vscode settings.

(Unless you don't use typescript to write your functions, then this is totally irrelevant. )

[ghost]

This is the minimal 'Hello World' example I came up with (Node 16 and ESM)
https://github.com/web2033/hello-esm-firebase

If I remove @google-cloud/functions-framework it won't deploy.

[taeold]

@web2033 I was able to deploy my function packaged as an ES module without including the @google-cloud/functions-framework package.

Maybe GCF team is slowing rolling out new version of the buildpack that includes the latest version of the @google-cloud/functions-framework, and I got lucky to be included in the early release batch.

[ghost]

Node 16?

[taeold]

@web2033 Oh interesting. Deploying Node 16 function fails for me as well. Node 14 works.

[ghost]

Do we need an issue to track it? In which package?
cc @mbleigh

[taeold]

@web2033 The change needs to happen on Google Cloud Functions backend team. I've let them know - will ping this thread when the change is rolled out. If you prefer following an issue, feel free to open one in firebase-functions or open a public one is GCF.

https://issuetracker.google.com/issues?q=componentid:187195%20status:open#