Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where empty vpc connector setting was removed. #3973

Merged
merged 3 commits into from Dec 31, 2021
Merged

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Dec 28, 2021

Today, empty vpc connector setting is removed in the function update request, e.g.:

exports.vpc = functions.runWith({ vpcConnector: '' }).https.onRequest((request, response) => {
  functions.logger.info("Hello logs!", {structuredData: true});
  response.send("Hello from Firebase!");
});

This is unfortunate since the existing behavior makes it impossible to clear vpc connector setting (see #3968 for discussion). The change here preserves the empty string as a vpc connector setting which in turn allows someone to clear the vpc connector setting on deploy.

@taeold taeold requested a review from joehan December 28, 2021 22:00
@taeold taeold enabled auto-merge (squash) December 30, 2021 19:02
@taeold taeold merged commit 754c8e4 into master Dec 31, 2021
@bkendall bkendall deleted the dl-cf3-vpc-unset branch March 18, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants