Fix iOS auth for resumable uploads in Storage Emulator

[tohhsinpei]

Description

Issue(s)

This PR fixes #3550, possibly also #3584, #3765, and #3890.

Any upload via the iOS SDK gated by auth rules causes the Storage Emulator to crash. A permissions error occurs on the iOS side.

Cause

A resumable upload consists of two requests: start and upload, finalize. Clients are only expected to include an Authorization header in the first request. The 403 occurs because the emulator is expecting it in the second request as well. This bug does not occur for the other SDKs because they include the auth header in every request (e.g. JS, Android).

Scenarios Tested

Tested against example linked in issue and verified that 403 does not occur after fix.

[tonyjhuang]

Were you able to verify the ios sdk now works with these changes?

[tohhsinpei]

Were you able to verify the ios sdk now works with these changes?

Sort of... I ran the example against the changes. But I still need to set up the iOS integration tests as discussed and try it out there.

[hixfield]

@tohhsinpei I'm currently running into this issue (last couple of days). How can I get this fix early?

[tohhsinpei]

@tohhsinpei I'm currently running into this issue (last couple of days). How can I get this fix early?

@hixfield We're working on a new release but in the meantime you could clone this repo and work off a local build; instructions here.

[yareeh]

With firebase-tools 10.2.2. that according to the release notes contains this fix I still get

Error: An unexpected error has occurred.
error Command failed with exit code 2.

and emulator crash with this in rule in storage.rules:

request.auth != null && request.auth.uid != null;

If I have this in rule:

request.auth.uid != null;

The emulator crashes with:

⚠  com.google.firebase.rules.runtime.common.EvaluationException: Error: /Users/jari/git/albertine/firebase/storage.rules line [5], column [14]. Null value error.

Error: An unexpected error has occurred.
error Command failed with exit code 2.

[tohhsinpei]

With firebase-tools 10.2.2. that according to the release notes contains this fix I still get

Error: An unexpected error has occurred.
error Command failed with exit code 2.

and emulator crash with this in rule in storage.rules:

request.auth != null && request.auth.uid != null;

If I have this in rule:

request.auth.uid != null;

The emulator crashes with:

⚠  com.google.firebase.rules.runtime.common.EvaluationException: Error: /Users/jari/git/albertine/firebase/storage.rules line [5], column [14]. Null value error.

Error: An unexpected error has occurred.
error Command failed with exit code 2.

@yareeh I wasn't able to reproduce this. Could you provide the full contents of your storage.rules as well as the firebase-debug.log?

[yareeh]

@tohhsinpei – I updated the iOS SDK to 8.13.0 and now it works.