Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable ordering of *.env generated by firebase ext:export #4256

Closed
therefromhere opened this issue Mar 7, 2022 · 1 comment · Fixed by #4267
Closed

Unstable ordering of *.env generated by firebase ext:export #4256

therefromhere opened this issue Mar 7, 2022 · 1 comment · Fixed by #4267

Comments

@therefromhere
Copy link

[REQUIRED] Environment info

firebase-tools: 10.2.2

Platform: Ubuntu

[REQUIRED] Test case

In a project with a firebase extension installed (eg firebase/firestore-bigquery-export), firebase ext:export would ideally
product stable env files.

It doesn't, I've not debugged but my hunch this is due to JS dict ordering?

Could the tool be updated to sort the env vars by name before output, so that the files are stable?

[REQUIRED] Steps to reproduce

firebase ext:export -f
git commit -a
firebase ext:export -f
git diff

[REQUIRED] Expected behavior

Consecutive runs of firebase ext:export would produce extensions/*.env files that are stable.

[REQUIRED] Actual behavior

The *.env file line order changes with each run.

@joehan joehan self-assigned this Mar 7, 2022
@joehan
Copy link
Contributor

joehan commented Mar 7, 2022

This is a very reasonable feature request - I'll take some time to work on it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants