Trigger parser can create callable triggers #4310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
force-pushed
the
inlined.callable-trigger-fix
branch
from
ac760c6
to
563e91a
Compare
taeold
force-pushed
the
inlined.callable-trigger-fix
branch
from
563e91a
to
8ca3d43
Compare
taeold
approved these changes
Mar 16, 2022
bkendall
approved these changes
Mar 16, 2022
taeold
added a commit
that referenced
this pull request
Mar 17, 2022
Fixes #4313 In #4310, we started to support new type of triggers `callableTrigger` (distinct from `httpTrigger`). Functions Emulator does not support `callableTrigger`. We fix this by converting `callbleTrigger` to `httpTrigger`. This is tech debt - at some point, we should use `endpoint` definitions throughout the emulator (cc @joehan). Also adds integration tests for emulating callable triggers to prevent this kind of breakages in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4307 and #4302.
endpointFromFunctionwas correctly identifying thatlabels["deployment-callable"]gives an endpoint acallableTriggerbutparseTriggers.tshad no codepath that gave them acallableTrigger(instead falling back to anhttpsTriggerrand labels).