New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update /internal/setRules endpoint; fix ruleset file watcher #4337
Merged
tohhsinpei
merged 6 commits into
master
from
hsinpei/storage-emulator-multiple-targets-5
Mar 30, 2022
Merged
Update /internal/setRules endpoint; fix ruleset file watcher #4337
tohhsinpei
merged 6 commits into
master
from
hsinpei/storage-emulator-multiple-targets-5
Mar 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohhsinpei
commented
Mar 18, 2022
@@ -103,10 +91,15 @@ class DefaultStorageRulesManager implements StorageRulesManager { | |||
"storage", | |||
"Change detected, updating rules for Cloud Storage..." | |||
); | |||
this.updateRulesSource(rulesFile); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the fix for 2)
tonyjhuang
reviewed
Mar 21, 2022
tohhsinpei
force-pushed
the
hsinpei/storage-emulator-multiple-targets-5
branch
2 times, most recently
from
March 23, 2022 19:56
ecd59d1
to
4fc31d0
Compare
tonyjhuang
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2 changes:
/internal/setRules
endpoint. Note that we only allow callers to overwrite the entire rules config, not update rules for a given resource. This means we can kill theupdateSourceFile
endpoint on the rules manager.firebase-tools/scripts/storage-emulator-integration/rules/manager.test.ts
Line 102 in 089bea2
Note
opts
does not containruleset
, so this always returns false:firebase-tools/src/emulator/storage/rules/utils.ts
Lines 71 to 77 in 089bea2