Add deprecation notice for Java<11. #4347
Merged
+138
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR checks the Java version before starting emulators that require Java, and warns if Java version <= 11 or cannot be determined.
As a side effect, this also catches situations where the
java
command is not actually Java, and fixes #4116.Scenarios Tested
Manually tested
emulators:start
andemulators:exec
with Java 11 and Java 8. Only Java 8 leads to warnings. Tried to emptyPATH
and got the Java not installed error as expected.Could use some help testing on OS X WITHOUT Java.
Sample Commands
To increase visibility, the deprecation notice is printed again after start (or at the very end for
emulators:exec
).Internal note: Crashlytics is not affected by the deprecation (i.e. keeping Java 8 support), so we're not adding a check or warnings there. (Googlers: See go/crashlytics-android-cli for more info)