Only validate function name #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
Mar 22, 2022
src/emulator/functionsEmulator.ts
Outdated
| functionIdsAreValid([definition]); | ||
| // Note - in the emulator, functionId = {region}-{functionName}, but in prod, functionId=functionName. | ||
| // To match prod behavior, only validate functionName | ||
| functionIdsAreValid([{ id: definition.name, platform: definition.platform }]); |
There was a problem hiding this comment.
personal pref, but I'd do something like:
functionIdsAreValid([{ ...definition, id: definition.name }]);
There was a problem hiding this comment.
Ahhh, i do like this a bit more - done.
Co-authored-by: Daniel Lee <danielylee@google.com>
tohhsinpei
pushed a commit
that referenced
this pull request
Mar 23, 2022
* Only validate function name * Add changelog entry * Update CHANGELOG.md Co-authored-by: Daniel Lee <danielylee@google.com> * PR fixes Co-authored-by: Daniel Lee <danielylee@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing the extensions emulator, I noticed that this length validation on functionId was blocking some function names that would be valid in prod. In the emulator, functionId = {region}-{functionName}, but in prod, functionId=functionName. Therefore, to match prod behavior, we should only validate functionName.