Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage emulator returning wrong host for upload URL's #4374

Closed
dermasmid opened this issue Mar 30, 2022 · 1 comment · Fixed by #4409
Closed

Storage emulator returning wrong host for upload URL's #4374

dermasmid opened this issue Mar 30, 2022 · 1 comment · Fixed by #4409
Assignees

Comments

@dermasmid
Copy link
Contributor

dermasmid commented Mar 30, 2022

[REQUIRED] Environment info

firebase-tools: 10.5.0

Platform: macOS

[REQUIRED] Test case

[REQUIRED] Steps to reproduce

  1. create docker contianer with storage emulator in it and make it listen to "host": "0.0.0.0" (so it can be accessed from outside the container)
  2. create a second container and try to upload a file to the emulator

what will happen is that it will try to connect to 0.0.0.0 and it will fail

[REQUIRED] Expected behavior

the emulator should not return the bind host, instead return the req.hostname

[REQUIRED] Actual behavior

emulator uses the bing host to determine the host

related issue: googleapis/nodejs-storage#1611

@dermasmid dermasmid added the bug label Mar 30, 2022
@google-oss-bot
Copy link
Contributor

This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants