Fix missing upload status header in resumable upload finalise response

[tohhsinpei]

Description

Issue

This PR fixes #4346, #4364, and #4396.

Any large (> ~500kB) upload to the Storage Emulator gives a console error.

On web:

Uncaught (in promise) FirebaseError: Firebase Storage: An unknown error occurred, please check the error payload for server response. (storage/unknown)

On iOS:

2022-03-31 16:50:05.822789-0400 Example[51380:621771] offset 438491 exceeds data length 438491
2022-03-31 16:50:05.823434-0400 Example[51380:622628] Range invalid for upload data.  offset: 438491	length: 8491	dataLength: 438491	expected UploadLength: 438491
2022-03-31 16:50:08.017868-0400 Example[51380:622083] [javascript] Possible Unhandled Promise Rejection (id: 0):

On the emulator UI, the upload is shown with a loading spinner indefinitely. However, on refresh we see that the file was in fact uploaded successfully.

This issue started in v10.3.0.

Cause

In #4250 we refactored the upload logic. In doing so we forgot to include the header X-Goog-Upload-Status with value final in the response for the finalize request. My guess is that the client expects to make further upload requests and errors out when there are no more bytes to upload.

Scenarios Tested

Tested on web and verified that console error no longer appears and that the header is included in the response. Also included a check for the latter in an existing integration test for resumable uploads.

[tonyjhuang]

Wow nice find! Do we need to do this in gcloud.ts as well?

[tohhsinpei]

Wow nice find! Do we need to do this in gcloud.ts as well?

No... The way the Admin SDK does it is a bit different. It'll just be one POST to start then one PUT to upload and finalise.

[tonyjhuang]

SGTM thanks for the PR