Fix cross-platform incompatibility with Storage Emulator exports #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjhuang
reviewed
Apr 7, 2022
tonyjhuang
reviewed
Apr 7, 2022
...ows-emulator-data/storage_export/metadata/fake-project-id.appspot.com%5Ctest_upload.jpg.json
Show resolved
Hide resolved
tonyjhuang
reviewed
Apr 7, 2022
tonyjhuang
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #4322 (comment), hopefully the last follow up to #3647. The Storage emulator is unable to import data previously exported on a different platform because we didn't account for different file path formats (e.g.
\delimiter on Windows but/on Linux) when flattening the directory structure.Note re: the fix implemented here: ideally I would store and export everything in POSIX file format, then do the obvious replacement when importing. But I don't think that's a good idea for backwards compatibility reasons. Lmk if you have thoughts.
Scenarios Tested
Added integration test to verify that emulator is able to import data previously exported on Windows.