Catch OSX port 5000 in-use #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
Apr 8, 2022
| // enough devexp that we should special case and ensure it's available. | ||
| if (process.platform === "darwin") { | ||
| try { | ||
| execSync(`lsof -i :${port}`); |
There was a problem hiding this comment.
Looking through this, it seems like this only checks if the initial port is being used by osX, and will still break out if a subsequent attempt hits a osx occupied port. Should we include this if (platform == 'darwin') lsof in portInUse() as well?
There was a problem hiding this comment.
portInUse recurses, so it should work in subsequent attempts
|
@joehan thanks for the quick turn around on your reviews today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSX is reserving port 5000 in a way that Node's http server is not erroring when you listen on it. Add a special case for this.