-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sharp library to Next.js build #5238
Conversation
Codecov ReportBase: 56.21% // Head: 56.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## jamesdaniels_skip_middleware_matches #5238 +/- ##
========================================================================
- Coverage 56.21% 56.21% -0.01%
========================================================================
Files 308 309 +1
Lines 20808 20819 +11
Branches 4224 4226 +2
========================================================================
+ Hits 11697 11703 +6
- Misses 8102 8107 +5
Partials 1009 1009
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add changelog entry
instead of simply looking for the `/app` directory
Description
Checking for /app dir and nextImage to add the sharp library to the Next.js build.
Scenarios Tested
In order to add the sharp library the code is looking for two things:
/app
folder existsisNextImageImported
is set totrue
in.next/export-marker.json
Sample Commands