Flutter Web support #5332
Flutter Web support #5332
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5332 +/- ##
==========================================
+ Coverage 55.21% 55.25% +0.04%
==========================================
Files 325 327 +2
Lines 22261 22291 +30
Branches 4538 4544 +6
==========================================
+ Hits 12291 12317 +26
- Misses 8879 8880 +1
- Partials 1091 1094 +3
☔ View full report in Codecov by Sentry. |
src/frameworks/flutter/index.ts
Outdated
|
|
||
| export function build(cwd: string): Promise<BuildResult> { | ||
| checkForFlutterCLI(); | ||
| const build = execSync(`flutter build web --release`, { |
There was a problem hiding this comment.
| const build = execSync(`flutter build web --release`, { | |
| const build = execSync(`flutter build web`, { |
--release is the default
There was a problem hiding this comment.
How is customization handled here? Folks might want to pass a number of things to the CLI...
There was a problem hiding this comment.
Fair q.
Short term, we have a target environment variable landing soon e.g, FIREBASE_HOSTING_BUILD_TARGET=profile
Long term, one will be able to override the build command.
Mid term... what are the most common?
I could see respecting a FIREBASE_HOSTING_BUILD_ARGS="..." env variable
|
Test coverage and changelog coming right up |
Description
Scenarios Tested
Sample Commands