Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new links added to the release object (release links) #5405

Merged
merged 8 commits into from
Jan 18, 2023
Merged

Add support for new links added to the release object (release links) #5405

merged 8 commits into from
Jan 18, 2023

Conversation

manny-jimenez
Copy link
Contributor

@manny-jimenez manny-jimenez commented Jan 8, 2023 •
edited

Printing links that will be added to the Release Object. There are three links.

  1. Firebase Console link for devs to link to a specific release in the console
  2. Testing Link for devs to send to testers to test a specific release
  3. Binary Link to download the binary associated with that release

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023 •
edited

Codecov Report

Base: 56.32% // Head: 56.31% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e7fc59b) compared to base (6ed2e7f).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5405      +/-   ##
==========================================
- Coverage   56.32%   56.31%   -0.01%     
==========================================
  Files         315      315              
  Lines       21325    21325              
  Branches     4349     4349              
==========================================
- Hits        12011    12009       -2     
- Misses       8273     8274       +1     
- Partials     1041     1042       +1
Impacted Files Coverage Δ
src/appdistribution/client.ts 91.80% <ø> (ø)
src/emulator/auth/state.ts 84.87% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manny-jimenez manny-jimenez marked this pull request as ready for review January 18, 2023 15:38
@manny-jimenez manny-jimenez enabled auto-merge (squash) January 18, 2023 16:02
rebehe
rebehe approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@rebehe rebehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - just remember to rename this PR

@manny-jimenez manny-jimenez changed the title Manny release links Add support for new links added to the release object (release links) Jan 18, 2023
@manny-jimenez manny-jimenez enabled auto-merge (squash) January 18, 2023 18:58
@manny-jimenez manny-jimenez changed the base branch from master to distro_release_links January 18, 2023 21:45
@manny-jimenez manny-jimenez merged commit f30da73 into firebase:distro_release_links Jan 18, 2023
manny-jimenez added a commit that referenced this pull request Jan 18, 2023
@manny-jimenez
Add support for new links added to the release object (release links) (…
661b3aa 
…#5405) (#5438)

* [WIP] Adding release links to firebase cli

* Update client.spec.ts

* Update appdistribution-distribute.ts

* Update appdistribution-distribute.ts

Co-authored-by: Manny Jimenez <mannyjimenez@google.com>

Co-authored-by: Manny Jimenez <mannyjimenez@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebehe rebehe rebehe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manny-jimenez @codecov-commenter @rebehe