Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file: dependency support for web frameworks #5440

Merged

Conversation

austincrim
Copy link
Contributor

Description

This PR re-introduces the ability to bundle and deploy a local dependency to Firebase Functions (when using web frameworks) by specifying the dependency version as file:./some-path.

If the specified path is a folder, it will run npm pack and copy the tarball into the deployed functions folder. If the specified path is a file, it will copy it directly to the functions folder.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look into relative dirs and add a changelog, otherwise LGTM

@jamesdaniels jamesdaniels self-assigned this Jan 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Base: 56.22% // Head: 56.18% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a790c47) compared to base (416d034).
Patch coverage: 5.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5440      +/-   ##
==========================================
- Coverage   56.22%   56.18%   -0.04%     
==========================================
  Files         317      317              
  Lines       21442    21457      +15     
  Branches     4376     4380       +4     
==========================================
  Hits        12056    12056              
- Misses       8326     8341      +15     
  Partials     1060     1060              
Impacted Files Coverage Δ
src/emulator/storage/apis/shared.ts 9.09% <0.00%> (-0.59%) ⬇️
src/frameworks/index.ts 15.18% <7.14%> (-0.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@jamesdaniels jamesdaniels enabled auto-merge (squash) February 1, 2023 19:39
@jamesdaniels jamesdaniels merged commit 3023c17 into firebase:master Feb 1, 2023
@austincrim austincrim deleted the add-file-dependency-support branch February 1, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants