fix ng discover, relative init, and nextjs javascript flavor #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 56.19% // Head: 56.19% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #5500 +/- ##
=======================================
Coverage 56.19% 56.19%
=======================================
Files 317 317
Lines 21461 21461
Branches 4381 4381
=======================================
Hits 12059 12059
Misses 8342 8342
Partials 1060 1060
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
leoortizz
approved these changes
Feb 10, 2023
| execSync(`npx --yes -p @angular/cli@latest ng new ${setup.hosting.source} --skip-git`, { | ||
| stdio: "inherit", | ||
| }); | ||
| export async function init(setup: any, config: any) { |
There was a problem hiding this comment.
it would be good to have a type for setup and config
There was a problem hiding this comment.
SG. I'll take in a follow on as we rework init to be testable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5146, and more