Add Astro web framework support #5527
Merged
+9,431
−3,171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5527 +/- ##
==========================================
+ Coverage 55.71% 55.78% +0.06%
==========================================
Files 322 324 +2
Lines 21836 21892 +56
Branches 4454 4462 +8
==========================================
+ Hits 12166 12212 +46
- Misses 8602 8606 +4
- Partials 1068 1074 +6
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Closed
jamesdaniels
approved these changes
Apr 13, 2023
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
Co-authored-by: James Daniels <jamesdaniels@google.com>
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
Co-authored-by: James Daniels <jamesdaniels@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In conjunction with FirebaseExtended/firebase-framework-tools#61, this PR adds Astro support to Firebase web frameworks.
A temp change was made inframeworks/index.tsto support ESM, but another PR (#5540) is open that should fix this. That PR should be merged before this one.Scenarios Tested
Tested with the Astro skeleton template, including static site generation, API routes, and partial hydration with a Svelte component.