Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG.md missing from extensions template #5530

Closed
cabljac opened this issue Feb 17, 2023 · 3 comments · Fixed by #5554
Closed

CHANGELOG.md missing from extensions template #5530

cabljac opened this issue Feb 17, 2023 · 3 comments · Fixed by #5554

Comments

@cabljac
Copy link

cabljac commented Feb 17, 2023

[REQUIRED] Environment info

firebase-tools: 11.20.0 and 11.23.1

Platform: macOS

[REQUIRED] Test case

(this is a CLI issue)

[REQUIRED] Steps to reproduce

In a fresh directory run firebase ext:dev:init and follow prompts

[REQUIRED] Expected behavior

The command should execute without error and create an extension project from the template in the directory

[REQUIRED] Actual behavior

Complains that CHANGELOG.md is missing in the template. If I manually add the changelog file, the command works.

Screenshot 2023-02-17 at 10 42 12

❯ firebase ext:dev:init --debug
? In which language do you want to write the Cloud Functions for your extension? JavaScript
? Do you want to use ESLint to catch probable bugs and enforce style? No
[2023-02-17T10:43:00.380Z] Error: ENOENT: no such file or directory, open '/Users/jacobcable/.nvm/versions/node/v14.19.1/lib/node_modules/firebase-tools/templates/extensions/CHANGELOG.md'
    at Object.openSync (fs.js:497:3)
    at Object.readFileSync (fs.js:393:35)
    at readCommonTemplates (/Users/jacobcable/.nvm/versions/node/v14.19.1/lib/node_modules/firebase-tools/lib/commands/ext-dev-init.js:27:31)
    at javascriptSelected (/Users/jacobcable/.nvm/versions/node/v14.19.1/lib/node_modules/firebase-tools/lib/commands/ext-dev-init.js:131:23)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async Command.actionFn (/Users/jacobcable/.nvm/versions/node/v14.19.1/lib/node_modules/firebase-tools/lib/commands/ext-dev-init.js:55:17)

Error: Error occurred when initializing files for new extension: ENOENT: no such file or directory, open '/Users/jacobcable/.nvm/versions/node/v14.19.1/lib/node_modules/firebase-tools/templates/extensions/CHANGELOG.md'
@joehan joehan self-assigned this Feb 21, 2023
@joehan
Copy link
Contributor

joehan commented Feb 21, 2023

I'm pretty confused by this one, since https://github.com/firebase/firebase-tools/blob/master/templates/extensions/CHANGELOG.md exists, and I'm not able to replicate it locally. I also tried running npm pack to see if that was removing the CHANGELOG.md file, and it was not.

Will keep digging.

@joehan
Copy link
Contributor

joehan commented Feb 24, 2023

Update - with help from @ifielker, I've repro'd this and I'm working on a fix

@cabljac
Copy link
Author

cabljac commented Feb 27, 2023

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants