Fix bug where EVENTARC_CLOUD_EVENT_SOURCE environment variable was correctly set for some functions. #5597
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly set for some functions.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #5597 +/- ##
=======================================
Coverage 56.12% 56.12%
=======================================
Files 317 317
Lines 21510 21510
Branches 4391 4391
=======================================
Hits 12072 12072
Misses 8376 8376
Partials 1062 1062
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
joehan
reviewed
Mar 15, 2023
| @@ -0,0 +1 @@ | |||
| - Fix bug where EVENTARC_CLOUD_EVENT_SOURCE environment variable was correctly set for some functions. (#5597) | |||
There was a problem hiding this comment.
Suggested change
| - Fix bug where EVENTARC_CLOUD_EVENT_SOURCE environment variable was correctly set for some functions. (#5597) | |
| - Fixes bug where EVENTARC_CLOUD_EVENT_SOURCE environment variable was incorrectly set for some functions. (#5597) |
joehan
approved these changes
Mar 15, 2023
|
Ahhh, missed that you had automerge on - mind fixing the CHANGELOG in a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object containing environment variable was mistakenly shared for all function.
This is usually okay as CF3 doesn't allow user to define per-function environment variable. However, Firebase-defined
EVENTARC_CLOUD_EVENT_SOURCEenv var is unique per function and due to this bug, all but one function has correct value for it.Fixes #5333.