Fix bug where functions shell failed to invoke event triggered functions in debug mode. #5609
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons in debug mode.
blidd-google
approved these changes
Mar 16, 2023
colerogers
approved these changes
Mar 30, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5609 +/- ##
==========================================
- Coverage 55.98% 55.98% -0.01%
==========================================
Files 321 321
Lines 21660 21663 +3
Branches 4418 4419 +1
==========================================
Hits 12127 12127
- Misses 8468 8471 +3
Partials 1065 1065
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
…ons in debug mode. (firebase#5609) When running functions shell with `--inspect-functions` flag (aka debug mode), the shell command wasn't preparing the emulated process to execute the trigger invoked by the user. Including a small refactoring to add a property to the FunctionsEmulator class to denote whether it's in debug mode or not for clarity. I recognize that there isn't any test here. Sadly, there is no existing test suite for the functions shell command, and frankly I understand why - it's tricky to setup a test that requires interactive input. I'm intentionally not taking up the challenge to set up a test suite here since the bug is fairly small, but I do hope that we'll have time in the future to pay this tech debt (famous last words?). Fixes firebase#5567
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running functions shell with
--inspect-functionsflag (aka debug mode), the shell command wasn't preparing the emulated process to execute the trigger invoked by the user.Including a small refactoring to add a property to the FunctionsEmulator class to denote whether it's in debug mode or not for clarity.
I recognize that there isn't any test here. Sadly, there is no existing test suite for the functions shell command, and frankly I understand why - it's tricky to setup a test that requires interactive input. I'm intentionally not taking up the challenge to set up a test suite here since the bug is fairly small, but I do hope that we'll have time in the future to pay this tech debt (famous last words?).
Fixes #5567