Fix bug where eagerly initializing UA failed function deployment that imported firebase-tools as a library. #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… imported firebase-tools as a library. We will lazily initialize the UA agent to prevent CF3 deploy from failing when building function source that uses firebase-tools as a library. Not sure why this suddenly became a problem in nodejs18 - my guess is that the builder image for nodejs18 runtime have stricter permission on filesystem directories that configstore needs.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5666 +/- ##
=======================================
Coverage 55.92% 55.93%
=======================================
Files 322 322
Lines 21706 21708 +2
Branches 4427 4429 +2
=======================================
+ Hits 12140 12142 +2
+ Misses 8501 8500 -1
- Partials 1065 1066 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
yuchenshi
approved these changes
Apr 7, 2023
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
… imported firebase-tools as a library. (firebase#5666) Instead, we lazily initialize the UA agent to prevent CF3 deploy from failing when building function source that uses firebase-tools as a library. Not sure why this suddenly became a problem in nodejs18 - my guess is that the builder image for nodejs18 runtime have stricter permission on filesystem directories that configstore needs. Fixes firebase#5631.
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
… imported firebase-tools as a library. (#5666) Instead, we lazily initialize the UA agent to prevent CF3 deploy from failing when building function source that uses firebase-tools as a library. Not sure why this suddenly became a problem in nodejs18 - my guess is that the builder image for nodejs18 runtime have stricter permission on filesystem directories that configstore needs. Fixes #5631.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we lazily initialize the UA agent to prevent CF3 deploy from failing when building function source that uses firebase-tools as a library.
Not sure why this suddenly became a problem in nodejs18 - my guess is that the builder image for nodejs18 runtime have stricter permission on filesystem directories that configstore needs.
Fixes #5631.