Use the same secret label on create and update #5704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheIronDev
approved these changes
Apr 18, 2023
Berlioz
approved these changes
Apr 18, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5704 +/- ##
=======================================
Coverage 55.60% 55.60%
=======================================
Files 324 324
Lines 21980 21980
Branches 4480 4480
=======================================
+ Hits 12221 12222 +1
+ Misses 8679 8678 -1
Partials 1080 1080
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ProfHercules
pushed a commit
to ProfHercules/firebase-tools
that referenced
this pull request
May 5, 2023
* always use the `firebase-managed` label * add a test
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
* always use the `firebase-managed` label * add a test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5689. Per internal chat, the correct label is
firebase-managed, notfirebase-hosting-managed.Scenarios Tested
Added a test for matching labels, alongside the existing test for not-matching labels. I haven't manually tested this.
Sample Commands
N/A