Nuxt, baseURL, and SSG fixes #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jamesdaniels
commented
Apr 20, 2023
•
jamesdaniels
commented
- Handle Nuxt bundled dependencies
- Add fast dev-mode to Nuxt 2
- Handle ssr true/false in a more conventional way
- Call generate when targeting ssr: false
- Import all the integrations, rather than dynamically require
- Leave it to the framework to build an SPA
- Handle Nuxt3 baseURL
- SPAs for Nuxt3 and Angular now respect baseUrl
- If the Nuxt version couldn't be determined, assume Nuxt3
- Nuxt used process.cwd in a couple places, guard against this
- Fix serveOptimizedImages + SPA
jamesdaniels
commented
Apr 26, 2023
src/frameworks/index.ts
Outdated
| @@ -107,7 +109,7 @@ const SupportLevelWarnings = { | |||
| ), | |||
| }; | |||
|
|
|||
| export const FIREBASE_FRAMEWORKS_VERSION = "^0.7.0"; | |||
| export const FIREBASE_FRAMEWORKS_VERSION = "0.6.1-canary.35a57cb"; | |||
There was a problem hiding this comment.
This is in ^0.8.0 now
There was a problem hiding this comment.
Are we able to test this with experiments enabled on the Firebase CLI?
There was a problem hiding this comment.
Once merged and cut, yes. If you'd like to help verify the changes in this branch, you can install it manually via npm i -g github:firebase/firebase-tools#jamesdaniels_nuxtFixes
jamesdaniels
commented
Apr 26, 2023
leoortizz
approved these changes
May 19, 2023
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
Co-authored-by: Leonardo Ortiz <leo@monogram.io>
|
Going to clean up my use of |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5716 +/- ##
==========================================
+ Coverage 55.10% 55.44% +0.34%
==========================================
Files 333 333
Lines 22892 23194 +302
Branches 4684 4787 +103
==========================================
+ Hits 12614 12861 +247
- Misses 9150 9213 +63
+ Partials 1128 1120 -8
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.