Enable the pinTags experiment by default #5753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jamesdaniels
commented
Apr 28, 2023
•
jamesdaniels
commented
- Block deploys that might affect production Block deploys to preview channels if would break prod #5731
- Append to --only deploying --only hosting also deploys tagged functions #5741
- Fix run pinTags Fix tag pinning for run servcies and functions with different svc ids #5742
- Handle preview channels Add only to channel deploys to pull in pinned functions #5751
- Add permission to the Github Action Handle permissions for pinTags and the Github Action #5749
- Github Action permission check moves permissions check to be earlier and conditional. #5757
- Revert target/only adding for frameworks Fix web frameworks SSR w/o pintags #5778
- No longer hide pins from discovery cl/528542727
- Documentation plan go/pintags-doc-plan
- Bug bash go/pintag-bug-bash
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5753 +/- ##
==========================================
- Coverage 55.21% 55.09% -0.12%
==========================================
Files 325 325
Lines 22218 22351 +133
Branches 4521 4606 +85
==========================================
+ Hits 12267 12315 +48
- Misses 8863 8949 +86
+ Partials 1088 1087 -1
☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
jamesdaniels
force-pushed
the
jamesdaniels_openPinTagsExp
branch
from
f3f6f37
to
189e907
Compare
jamesdaniels
changed the title
bkendall
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.