Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add init support for Flutter web #5864

Merged
merged 11 commits into from
May 19, 2023
Merged

Add init support for Flutter web #5864

merged 11 commits into from
May 19, 2023
+252 −53

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 19, 2023 •
edited
Loading

  • Add docs for Flutter Web
  • Add init support for Flutter Web
  • cross-spawn was returning status undefined in some cases, handle
  • Cleanup on the WF docs

@jamesdaniels jamesdaniels requested a review from inlined May 19, 2023 16:46
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 47.61% and no project coverage change.

Comparison is base (3ff7994) 55.09% compared to head (bbbd279) 55.10%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5864   +/-   ##
=======================================
  Coverage   55.09%   55.10%           
=======================================
  Files         332      333    +1     
  Lines       22878    22892   +14     
  Branches     4681     4684    +3     
=======================================
+ Hits        12605    12614    +9     
- Misses       9147     9150    +3     
- Partials     1126     1128    +2
Impacted Files Coverage Δ
src/frameworks/astro/index.ts 84.44% <0.00%> (ø)
src/frameworks/flutter/utils.ts 66.66% <0.00%> (-13.34%) ⬇️
src/frameworks/index.ts 11.56% <0.00%> (ø)
src/frameworks/next/index.ts 13.88% <0.00%> (ø)
src/frameworks/angular/index.ts 26.19% <33.33%> (+0.58%) ⬆️
src/frameworks/flutter/index.ts 82.35% <63.63%> (-5.65%) ⬇️
src/frameworks/flutter/constants.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

inlined
inlined approved these changes May 19, 2023
View reviewed changes
inlined
inlined reviewed May 19, 2023
View reviewed changes
@inlined
Copy link
Member

inlined commented May 19, 2023

Please fix unit test failures too

@jamesdaniels jamesdaniels enabled auto-merge (squash) May 19, 2023 18:18
@jamesdaniels jamesdaniels disabled auto-merge May 19, 2023 18:19
@jamesdaniels jamesdaniels merged commit ab9b07f into master May 19, 2023
@jamesdaniels jamesdaniels deleted the jamesdaniels_flutterInit branch May 19, 2023 18:26
tonyjhuang pushed a commit that referenced this pull request May 22, 2023
@jamesdaniels @tonyjhuang
Add init support for Flutter web (#5864)
b3da82a 
* Add init support for Flutter Web
* cross-spawn was returning status undefined, handle
* Add docs for Flutter Web
* Fix doc up a bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined

Assignees
No one assigned
Labels
integration: web frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesdaniels @codecov-commenter @inlined