Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow web frameworks to target Node v20 #5879

Merged
merged 4 commits into from
May 23, 2023
Merged

Conversation

jamesdaniels
Copy link
Member

Description

Scenarios Tested

Sample Commands

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5c7fa9f) 54.97% compared to head (b326b41) 54.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5879   +/-   ##
=======================================
  Coverage   54.97%   54.97%           
=======================================
  Files         333      333           
  Lines       22980    22980           
  Branches     4711     4711           
=======================================
  Hits        12634    12634           
  Misses       9218     9218           
  Partials     1128     1128           
Impacted Files Coverage Δ
src/frameworks/constants.ts 83.87% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jamesdaniels jamesdaniels requested a review from joehan May 23, 2023 18:48

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jamesdaniels jamesdaniels merged commit cbd92e8 into master May 23, 2023
@jamesdaniels jamesdaniels deleted the jamesdaniels_allowNode20 branch May 23, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants