Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow on fixes for #5892 #5895

Merged
merged 14 commits into from
May 25, 2023
Merged

Conversation

jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented May 24, 2023

  • Don't allow the devModeHandle if purpose is deploy
  • context._name is gone?! Manually pass "purpose" rather than leaning poorly typed options
  • Get more defensive w/types
  • Rename purpose of "serve" to "emulate"
  • Drop the Node 16 check, since v12 is 16+
  • Purpose of "test" should default to production target
  • Reject the devModeHost if process exits
  • Replace old broken e2e test with the new frameworks test

Fixes #5896

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch coverage: 16.12% and project coverage change: +0.01 🎉

Comparison is base (e57b49a) 55.01% compared to head (3573228) 55.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5895      +/-   ##
==========================================
+ Coverage   55.01%   55.03%   +0.01%     
==========================================
  Files         333      333              
  Lines       22961    22959       -2     
  Branches     4709     4708       -1     
==========================================
+ Hits        12633    12635       +2     
+ Misses       9200     9196       -4     
  Partials     1128     1128              
Impacted Files Coverage Δ
src/deploy/index.ts 30.23% <0.00%> (ø)
src/emulator/commandUtils.ts 27.63% <0.00%> (ø)
src/emulator/controller.ts 12.73% <0.00%> (-0.07%) ⬇️
src/frameworks/angular/index.ts 23.52% <0.00%> (-0.24%) ⬇️
src/frameworks/nuxt2/index.ts 39.65% <0.00%> (-0.70%) ⬇️
src/frameworks/utils.ts 38.98% <0.00%> (+1.27%) ⬆️
src/frameworks/vite/index.ts 29.03% <0.00%> (-0.48%) ⬇️
src/frameworks/index.ts 11.48% <12.50%> (+0.20%) ⬆️
src/frameworks/astro/index.ts 84.78% <100.00%> (+0.33%) ⬆️
src/frameworks/nuxt/index.ts 56.66% <100.00%> (+0.73%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jamesdaniels jamesdaniels changed the title Allow for development deploys to production Follow on fixes for #5892 May 25, 2023
@jamesdaniels jamesdaniels requested a review from joehan May 25, 2023 16:49
src/frameworks/index.ts Outdated Show resolved Hide resolved
src/frameworks/index.ts Outdated Show resolved Hide resolved
@jamesdaniels jamesdaniels requested a review from joehan May 25, 2023 18:17
src/frameworks/interfaces.ts Outdated Show resolved Hide resolved
@jamesdaniels jamesdaniels enabled auto-merge (squash) May 25, 2023 20:58
@jamesdaniels jamesdaniels merged commit 51d2fd5 into master May 25, 2023
31 checks passed
@jamesdaniels jamesdaniels deleted the jamesdaniels_additionalGuardRail branch May 25, 2023 21:08
@joehan joehan mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firebase deploy with webframeworks (nextjs) experiments no longer work on firebase-tools@12.2.0
3 participants