App Distribution: Add commands to manage groups #5978
Conversation
| import { AppDistributionClient } from "../appdistribution/client"; | ||
| import { getProjectName } from "../appdistribution/options-parser-util"; | ||
|
|
||
| export const command = new Command("appdistribution:group:create <displayName> [alias]") |
There was a problem hiding this comment.
Should alias be a named option for clarity?
There was a problem hiding this comment.
I had it as an option before, but then changed my mind and decided against it. Mainly because it's an argument in group:delete - and I didn't want to change that.
| .before(requireAuth) | ||
| .action(async (emails: string[], options?: any) => { | ||
| const projectName = await getProjectName(options); | ||
| const appDistroClient = new AppDistributionClient(); | ||
| const emailsToAdd = getEmails(emails, options.file); | ||
| utils.logBullet(`Adding ${emailsToAdd.length} testers to project`); | ||
| await appDistroClient.addTesters(projectName, emailsToAdd); | ||
| if (options.groupAlias) { | ||
| utils.logBullet(`Adding ${emailsToAdd.length} testers to group`); |
There was a problem hiding this comment.
nit: Consider changing the plurality of testers depending on the length of the emails, like
firebase-tools/src/commands/ext-configure.ts
Line 145 in f5671f1
There was a problem hiding this comment.
I'm too lazy - there are too many places to change
kaibolay
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5978 +/- ##
==========================================
+ Coverage 54.91% 54.95% +0.04%
==========================================
Files 342 342
Lines 23247 23264 +17
Branches 4753 4754 +1
==========================================
+ Hits 12766 12785 +19
+ Misses 9351 9350 -1
+ Partials 1130 1129 -1
☔ View full report in Codecov by Sentry. |
kaibolay
force-pushed
the
kb/more_group_management
branch
from
f955bb1 to
a670362
Compare
kaibolay
requested review from
bkendall and
joehan
and removed request for
bkendall
Description
appdistribution:group:createandappdistribution:group:delete.--group-aliasoption toappdistribution:testers:addandappdistribution:testers:remove.Sample Commands