Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run-time error in deploy script: clc is not defined #912

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

arayaryoma
Copy link
Contributor

Description

When tried to deploy Firebase Hosting project with firebase deploy --only hosting using firebase-tools v4.2.1, it would be failed because of the error below.

[debug] [2018-09-14T18:35:10.883Z] ----------------------------------------------------------------------
[debug] [2018-09-14T18:35:10.885Z] Command:       dir_to_node/node/v6.14.4/bin/node project_path/node_modules/.bin/firebase deploy --only hosting:staging
[debug] [2018-09-14T18:35:10.886Z] CLI Version:   4.2.1
[debug] [2018-09-14T18:35:10.886Z] Platform:      linux
[debug] [2018-09-14T18:35:10.886Z] Node Version:  v6.14.4
[debug] [2018-09-14T18:35:10.886Z] Time:          Sat Sep 15 2018 03:35:10 GMT+0900 (JST)
[debug] [2018-09-14T18:35:10.886Z] ----------------------------------------------------------------------
[debug] 
[debug] [2018-09-14T18:35:10.893Z] > command requires scopes: ["email","openid","https://www.googleapis.com/auth/cloudplatformprojects.readonly","https://www.googleapis.com/auth/firebase","https://www.googleapis.com/auth/cloud-platform"]
[debug] [2018-09-14T18:35:10.893Z] > authorizing via signed-in user
[debug] [2018-09-14T18:35:10.895Z] >>> HTTP REQUEST GET https://admin.firebase.com/v1/projects/sample-project  
 
[debug] [2018-09-14T18:35:12.107Z] <<< HTTP RESPONSE 200
[info] 
[info] === Deploying to 'sample-project'...
[info] 
[info] i  deploying hosting
[debug] [2018-09-14T18:35:14.848Z] ReferenceError: clc is not defined
    at project_path/node_modules/firebase-tools/lib/deploy/hosting/prepare.js:45:13
    at arrayEach (project_path/node_modules/lodash/lodash.js:516:11)
    at Function.forEach (project_path/node_modules/lodash/lodash.js:9344:14)
    at module.exports (project_path/node_modules/firebase-tools/lib/deploy/hosting/prepare.js:37:5)
    at _chain (project_path/node_modules/firebase-tools/lib/deploy/index.js:26:38)
    at project_path/node_modules/firebase-tools/lib/deploy/index.js:83:14
    at process._tickDomainCallback (internal/process/next_tick.js:135:7)
[error] 
[error] Error: An unexpected error has occurred.

This PR is fixing this problem.

Scenarios Tested

Sample Commands

Copy link
Contributor

@laurenzlong laurenzlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing!

@laurenzlong laurenzlong merged commit eccd42a into firebase:master Sep 14, 2018
@arayaryoma
Copy link
Contributor Author

Thank you for merging!

joehan pushed a commit that referenced this pull request Apr 26, 2024
Re-add dataConnect specific api values as getters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants