Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, android): fix a null pointer exception that could occur when removing an event listener #10210

Merged
merged 1 commit into from Jan 5, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Jan 3, 2023

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #10164

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(auth, android): fix a null pointer exception that could occur when removing an even listener fix(auth, android): fix a null pointer exception that could occur when removing an event listener Jan 5, 2023
@rrousselGit
Copy link
Contributor

Some e2e test for this would be neat. But otherwise LGTM

@Lyokone
Copy link
Contributor Author

Lyokone commented Jan 5, 2023

Some e2e test for this would be neat. But otherwise LGTM

There are already some e2e tests for this case. I couldn't reproduce this error but it was reported through a crashlytics report.

@Lyokone Lyokone merged commit 72d2e97 into master Jan 5, 2023
@Lyokone Lyokone deleted the fix/10164 branch January 5, 2023 12:45
@firebase firebase locked and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] NPE: io.flutter.plugins.firebase.auth.FlutterFirebaseAuthPlugin.removeEventListeners
3 participants