Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firestore): add support for sum and average aggregated queries #11757

Merged
merged 30 commits into from
Jan 2, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Oct 23, 2023

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #11848

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone marked this pull request as draft October 23, 2023 09:12
@Lyokone Lyokone changed the title feat(firestore): add support for sum and average aggregated queries feat(firestore): add support for sum and average aggregated queries Nov 6, 2023
@Lyokone Lyokone marked this pull request as ready for review November 24, 2023 08:17
@larssn
Copy link
Contributor

larssn commented Dec 4, 2023

Any status on this? 😊

Great work btw!

@Lyokone Lyokone added the blocked: waiting-api-review Waiting for an internal API Review before merging label Dec 5, 2023
@Lyokone
Copy link
Contributor Author

Lyokone commented Dec 5, 2023

Hi @larssn, we are still waiting for an internal API Review to release this. It should come soon. In the mean time, I've updated this branch with master so you can start using it if needed:
pubpec.yaml

  cloud_firestore:
    git:
      url: https://github.com/firebase/flutterfire.git
      path: packages/cloud_firestore/cloud_firestore
      ref: feat/firestore-average-sum

@larssn
Copy link
Contributor

larssn commented Dec 7, 2023

Hi @larssn, we are still waiting for an internal API Review to release this. It should come soon. In the mean time, I've updated this branch with master so you can start using it if needed: pubpec.yaml

  cloud_firestore:
    git:
      url: https://github.com/firebase/flutterfire.git
      path: packages/cloud_firestore/cloud_firestore
      ref: feat/firestore-average-sum

Cool, might try it out, thank you.
However, I can't use it in production until it is officially released.

Fingers crossed it won't be too long. 🤞😊

@Luluch1412
Copy link

Hope it is being merged soon.
Actually it is not running on iOS?

@Lyokone Lyokone removed the blocked: waiting-api-review Waiting for an internal API Review before merging label Jan 2, 2024
@Lyokone Lyokone merged commit 82af6c2 into master Jan 2, 2024
23 checks passed
@Lyokone Lyokone deleted the feat/firestore-average-sum branch January 2, 2024 13:24
@firebase firebase locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloud_firestore] Support sum() and avg() aggregation queries
5 participants