fix(firestore): allow null
value to isEqualsTo
& isNotEqualsTo
in where()
query
#11896
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses a sentinel value to check whether
isEqualTo
orisNotEqualTo
have been explicitly set tonull
.The following PR also uses a sentinel value even though they cannot query with a
null
value:isLessThan
isLessThanOrEqualTo
isGreaterThan
isGreaterThanOrEqualTo
arrayContains
The following do not use the sentinel as their type differs from the rest (they're expecting a list of objects):
arrayContainsAny
whereIn
whereNotIn
Related Issues
Closes #11874
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?