Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): allow null value to isEqualsTo & isNotEqualsTo in where() query #11896

Merged
merged 12 commits into from
Nov 21, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 15, 2023

Description

This PR uses a sentinel value to check whether isEqualTo or isNotEqualTo have been explicitly set to null.

The following PR also uses a sentinel value even though they cannot query with a null value:

  • isLessThan
  • isLessThanOrEqualTo
  • isGreaterThan
  • isGreaterThanOrEqualTo
  • arrayContains

The following do not use the sentinel as their type differs from the rest (they're expecting a list of objects):

  • arrayContainsAny
  • whereIn
  • whereNotIn

Related Issues

Closes #11874

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit 3ee59a7 into master Nov 21, 2023
26 checks passed
@Lyokone Lyokone deleted the firestore-11874 branch November 21, 2023 11:01
@firebase firebase locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firestore] Not able to filter/query on fields that are null
4 participants