Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): revert changes to isLessThan, isLessThanOrEqualTo,isGreaterThan, isGreaterThanOrEqualTo & arrayContains. null is not valid.. #12017

Merged
merged 5 commits into from
Dec 12, 2023

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Dec 12, 2023

Description

Fixes the linked issue, I double checked on android. These queries isLessThan, isLessThanOrEqualTo,isGreaterThan, isGreaterThanOrEqualTo & arrayContains are all marked @NotNull for the values. See example:
screenshot_2023-12-12_at_10 45 51_720

Related Issues

fixes #12003

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley marked this pull request as ready for review December 12, 2023 13:48
@russellwheatley russellwheatley changed the title fix(firestore): revert changes to isLessThan, isLessThanOrEqualTo,isGreaterThan, isGreaterThanOrEqualTo & arrayContains. null is ignored. fix(firestore): revert changes to isLessThan, isLessThanOrEqualTo,isGreaterThan, isGreaterThanOrEqualTo & arrayContains. null is not valid.. Dec 12, 2023
@russellwheatley russellwheatley merged commit 2712ea4 into master Dec 12, 2023
24 checks passed
@russellwheatley russellwheatley deleted the firestore-12003 branch December 12, 2023 15:00
@firebase firebase locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] Unsupported operation error. Received: get(constraint). Expected: get(path). for 'list'
4 participants