fix(firestore, web): update setSettings to allow usage of a up-to-date persistence on web
#12041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyokone
changed the title
setSettings to allow usage of a up-to-date persistence on web
exaby73
approved these changes
Dec 28, 2023
Comment on lines
+185
to
+192
| external PersistentSingleTabManager persistentSingleTabManager( | ||
| PersistentSingleTabManagerSettings? settings, | ||
| ); | ||
|
|
||
| @JS() | ||
| external PersistentMultipleTabManager persistentMultipleTabManager( | ||
| PersistentSingleTabManagerSettings? settings, | ||
| ); |
There was a problem hiding this comment.
Is the aim to allow these in the future? (along with memoryEagerGarbageCollector() & memoryLruGarbageCollector())
There was a problem hiding this comment.
Yes we probably need to refactor the front facing API to expose those APIs. I have to draft the API Review
russellwheatley
approved these changes
Jan 16, 2024
dvoloshyn
reviewed
Feb 6, 2024
| } else { | ||
| cacheSizeBytes = settings.cacheSizeBytes; | ||
| localCache = firestore_interop |
There was a problem hiding this comment.
After deprecation of enablePersistence we no longer have an API to specify multiple tab behavior on Web. So, which tab manager will be used by default when I set persistenceEnabled: true on Web?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see title
Related Issues
fixes #12034
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?