Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change old documentation links of packages in README files #12136

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

ashwinair
Copy link
Contributor

@ashwinair ashwinair commented Jan 10, 2024

Description

Changes old firebase.flutter.dev/docs links to new firebase.google.com/docs
of these packages:

  • cloud_firestore
  • cloud_firestore_web
  • cloud_functions
  • cloud_functions_web
  • firebase_analytics
  • fiebase_app_check_web
  • firebase_app_installations_web
  • firebase_app_installations
  • firebase_core
  • firebase_database
  • firebase_database_web
  • firebase_dynamic_links
  • firebase_in_app_messaging
  • firebase_messaging
  • firebase_messaging_web
  • firebase_ml_model_downloader
  • firebase_performance
  • firebase_remote_config_web
  • firebase_storage
  • firebase_storage_web

Related Issues

closes #11995

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

google-cla bot commented Jan 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ashwinair ashwinair changed the title fix old doc links docs: change old documentation links of packages Jan 10, 2024
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR! I've made some more suggestions to remove links to deprecated website.

packages/firebase_storage/firebase_storage_web/README.md Outdated Show resolved Hide resolved
packages/firebase_storage/firebase_storage_web/README.md Outdated Show resolved Hide resolved
packages/cloud_functions/cloud_functions_web/README.md Outdated Show resolved Hide resolved
packages/cloud_functions/cloud_functions_web/README.md Outdated Show resolved Hide resolved
packages/cloud_firestore/cloud_firestore_web/README.md Outdated Show resolved Hide resolved
@ashwinair
Copy link
Contributor Author

Hi @russellwheatley :)

I removed the lines as you suggested. can you have a look and tell me if there is anything else I have to edit.

@russellwheatley
Copy link
Member

Sorry, @ashwinair, a PR has been merged that conflicts with this file packages/cloud_firestore_odm/cloud_firestore_odm_generator/README.md, do you mind resolving the conflict, please? Thanks 🙏

@ashwinair
Copy link
Contributor Author

ashwinair commented Jan 11, 2024

do you mind resolving the conflict, please?

@russellwheatley, resolved.

@russellwheatley russellwheatley changed the title docs: change old documentation links of packages docs: change old documentation links of packages in README files Jan 11, 2024
@russellwheatley russellwheatley merged commit 24b9ac7 into firebase:master Jan 11, 2024
4 checks passed
@ashwinair ashwinair deleted the fix_broken_links branch January 11, 2024 12:48
@firebase firebase locked and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_core] Link for "Getting Started" section on README should be updated
3 participants