Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): revert breaking change to where() API. null cannot be used for isEqualTo or isNotEqualTo in a query. #12164

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jan 16, 2024

Description

Reverting changes made in this PR: https://github.com/firebase/flutterfire/pull/11896/files

This constitutes a breaking change for users who are querying by passing wrapper values to all query options like below:

    ref.where(
      'field',
      isEqualTo: isEqualTo,
      isNotEqualTo: isNotEqualTo,
      isLessThan: isLessThan,
      isLessThanOrEqualTo: isLessThanOrEqualTo,
      isGreaterThan: isGreaterThan,
      isGreaterThanOrEqualTo: isGreaterThanOrEqualTo,
      arrayContains: arrayContains,
      arrayContainsAny: arrayContainsAny,
      whereIn: whereIn,
      whereNotIn: whereNotIn,
      isNull: isNull,
    );

Related Issues

fixes: #12130

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label Jan 17, 2024
@russellwheatley russellwheatley removed the blocked: do-not-merge PR blocked externally label Jan 25, 2024
@russellwheatley russellwheatley merged commit cff6f76 into master Jan 25, 2024
20 checks passed
@russellwheatley russellwheatley deleted the firestore-12130 branch January 25, 2024 15:36
@firebase firebase locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] sentinel value breaks wrappers
3 participants