Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore, windows): fix compilation issue on Windows #12375

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Feb 22, 2024

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #12359

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@SPiercer
Copy link

Thanks it works, i tried your changes locally and worked on the example app testing on my app now

Copy link

@SPiercer SPiercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes Worked on my device and in my app LGTM

@SPiercer
Copy link

@russellwheatley or @exaby73 can someone approve and merge those please we're severely blocked and we need to have a release soon

Copy link

@mesalih mesalih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've test it locally on my device and does resolves the issue.

Copy link

@PolaraPrince PolaraPrince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has helped me, so I am grateful.

@BirjuVachhani
Copy link

This fixes the issue on windows. I can confirm.

@SPiercer
Copy link

@exaby73 we're blocked by you man if you can see this please act.

@SPiercer
Copy link

@Lyokone How long usually PR stay until it gets merged?

@russellwheatley
Copy link
Member

@SPiercer - It won't be released until next week now. You can update your pubspec.yaml to depend on git master branch if you cannot wait.

@SPiercer
Copy link

@russellwheatley that's what I'm saying, it's not merged to master yet.

or do you mean depend on the fix branch?

@russellwheatley russellwheatley merged commit f24d0a7 into master Feb 23, 2024
20 of 21 checks passed
@russellwheatley russellwheatley deleted the fix/12359 branch February 23, 2024 16:06
@Aravind556
Copy link

Issue fixed.Thank You

@firebase firebase locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] [windows] error C2440: '<function-style-cast>' after updating to flutter 3.19
9 participants