-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore, windows): fix compilation issue on Windows #12375
Conversation
Thanks it works, i tried your changes locally and worked on the example app testing on my app now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Worked on my device and in my app LGTM
@russellwheatley or @exaby73 can someone approve and merge those please we're severely blocked and we need to have a release soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've test it locally on my device and does resolves the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has helped me, so I am grateful.
This fixes the issue on windows. I can confirm. |
@exaby73 we're blocked by you man if you can see this please act. |
@Lyokone How long usually PR stay until it gets merged? |
@SPiercer - It won't be released until next week now. You can update your |
@russellwheatley that's what I'm saying, it's not merged to master yet. or do you mean depend on the fix branch? |
Issue fixed.Thank You |
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
closes #12359
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?