fix(core, web): fix compatibility with TrustedTypes #12383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
22
to
26
| <!-- | ||
| If you wanna test the require-trusted-types-for CSP, uncomment the line below | ||
| and run the app in a browser that supports Trusted Types (e.g. Chrome 83+). | ||
| Note that you need to run the app in release mode till this issue is fixed: | ||
| https://github.com/requirejs/requirejs/issues/1832 |
There was a problem hiding this comment.
Suggested change
| <!-- | |
| If you wanna test the require-trusted-types-for CSP, uncomment the line below | |
| and run the app in a browser that supports Trusted Types (e.g. Chrome 83+). | |
| Note that you need to run the app in release mode till this issue is fixed: | |
| https://github.com/requirejs/requirejs/issues/1832 | |
| <!-- | |
| If you want to test the require-trusted-types-for CSP, uncomment the line below | |
| and run the app in a browser that supports Trusted Types (e.g. Chrome 83+). | |
| Note that you need to run the app in release mode until this issue is fixed: | |
| https://github.com/requirejs/requirejs/issues/1832 |
russellwheatley
approved these changes
Feb 23, 2024
Salakar
reviewed
Feb 23, 2024
| <!-- | ||
| If you wanna test the require-trusted-types-for CSP, uncomment the line below | ||
| and run the app in a browser that supports Trusted Types (e.g. Chrome 83+). | ||
| Note that you need to run the app in release mode till this issue is fixed: |
There was a problem hiding this comment.
Suggested change
| Note that you need to run the app in release mode till this issue is fixed: | |
| Note that you need to run the app in release mode until this issue is fixed: |
Salakar
reviewed
Feb 23, 2024
| @@ -19,10 +19,18 @@ | |||
| <meta charset="UTF-8" /> | |||
| <meta content="IE=Edge" http-equiv="X-UA-Compatible" /> | |||
|
|
|||
| <meta | |||
| <!-- | |||
| If you wanna test the require-trusted-types-for CSP, uncomment the line below | |||
There was a problem hiding this comment.
Suggested change
| If you wanna test the require-trusted-types-for CSP, uncomment the line below | |
| If you want to test the require-trusted-types-for CSP, uncomment the line below |
exaby73
approved these changes
Feb 27, 2024
|
A new version of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
closes #12301
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?