Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): fix an issue that would cause FieldValue.increment to be interpreted as double #12444

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Mar 7, 2024

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #12436

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@ZippyRainbow
Copy link

Hi @Lyokone,
This didn't seem to fix the issue with the int increment as it is still resulting in a double stored in firestore.
increment(1) should result in a stored value of a int
increment(1.0) should result in a stored value of a double.

@estien
Copy link

estien commented Mar 15, 2024

Hi @Lyokone, This didn't seem to fix the issue with the int increment as it is still resulting in a double stored in firestore. increment(1) should result in a stored value of a int increment(1.0) should result in a stored value of a double.

I can confirm this as an ongoing issue still. Since the value type changes from int to double in Firestore whenever FieldValue.increment is invoked, I have to patch the document using onDocumentWritten from Firebase Functions until a fix is in place.

Can this be looked at @Lyokone please?

LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
… be interpreted as double (firebase#12444)

* fix(firestore): fix an issue that would cause FieldValue.increment to be interpreted as double

* lower
LocLt-Mobile pushed a commit to guide-inc-org/guide-flutter_fire that referenced this pull request Apr 5, 2024
… be interpreted as double (firebase#12444)

* fix(firestore): fix an issue that would cause FieldValue.increment to be interpreted as double

* lower
@firebase firebase locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants