Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): deprecate databaseURL in favor of databaseId #12593

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Apr 5, 2024

Description

  • Updated user facing code to allow both databaseURL & databaseId. databaseId takes precedence over databaseURL if both are input. Otherwise, they have the same value (if one or the other are selected).
  • Refactored method channel, platform and web implementations to use databaseId naming.
  • Wrote unit test.
  • We can update pigeon and native code to use databaseId naming in a future PR, perhaps when databaseURL is removed.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Contributor

@exaby73 exaby73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just a couple of questions

@russellwheatley russellwheatley merged commit 8966f48 into master Apr 12, 2024
22 checks passed
@russellwheatley russellwheatley deleted the firestore-deprecate-databaseURL branch April 12, 2024 06:01
@firebase firebase locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants