New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(*): support initializing default FirebaseApp
instances from Dart
#6549
Conversation
appId: '1:448618578101:ios:2bc5c1fe2ec336f8ac3efc', | ||
messagingSenderId: '448618578101', | ||
projectId: 'react-native-firebase-testing', | ||
)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: trailing coma (here and other example apps)
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
…ssing initialization script (#7302)
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
7b53e5b
to
3fc7cc5
Compare
c18e3e3
to
152b46e
Compare
152b46e
to
b027192
Compare
FirebaseApp
instances from DartFirebaseApp
instances from Dart
Description
How it works
google-services.json
orGoogleService-Info.plist
(or iffirebase.initializeApp()
is not called fromindex.html
for web ) is available, then dart will not have a default app.FirebaseOptions
have been passed intoinitializeApp()
(without thename
parameter). Use these values to initialise default app.name
&FirebaseOptions
are passed in, use these values to create additional app.Untouched legacy plugins that internally initialise default app:
firebase_dynamic_links
firebase_in_app_messaging
firebase_ml_vision
(also deprecated)Untouched deprecated plugins:
firebase_admob
Untouched packages as they don't
initializeApp()
in example:firebase_performance
firebase_ml_custom
Problem packages
firebase_crashlytics
.iOS
requires this run script for your app to function. Your app will fail to build when using the run script (will also fail without) which fails with this error now we've removedGoogleServices.plist
:It appears this
upload-symbols
script is looking forGoogleServices.plist
propertyGOOGLE_APP_ID
(We pass this in dart code now via this propertyFirebaseOptions.appId
). This will probably require an intervention from Firebase Crashlytics team.Additional config
firebase_auth
. UsingverifyPhoneNumber()
API does require an update to the user'sios/Runner/Info.plist
, specifically adding the reverse client id as described in the documentation here. Also need to pass iniosClientId
in theFirebaseOptions
(see this commit).Related Issues
none.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?