Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Switch to v9 compat libaries #7041

Closed
Ehesp opened this issue Sep 22, 2021 · 11 comments
Closed

[web] Switch to v9 compat libaries #7041

Ehesp opened this issue Sep 22, 2021 · 11 comments
Assignees
Labels
platform: web Issues / PRs which are specifically for web.

Comments

@Ehesp
Copy link
Member

Ehesp commented Sep 22, 2021

Currently we recommend that users install the v8 Firebase SDK:

<script src="https://www.gstatic.com/firebasejs/8.6.1/firebase-app.js"></script>

With v9 released which no longer supports the window object, we will need to switch to the compat versions across all plugins.

<script src="https://www.gstatic.com/firebasejs/9.0.2/firebase-app-compat.js"></script>

The API is the same but uses the v9 SDK under the hood.

@Ehesp Ehesp added platform: web Issues / PRs which are specifically for web. Needs Attention This issue needs maintainer attention. labels Sep 22, 2021
@markusaksli-nc
Copy link
Contributor

FYI #6967

@ChristianEdwardPadilla
Copy link
Contributor

ChristianEdwardPadilla commented Jun 7, 2022

@russellwheatley Any updates on the web refactor to integrate with V9 web SDK (mentioned as last comment here: #7215)? Any place we can track progress and offer help?

@russellwheatley
Copy link
Member

russellwheatley commented Jun 8, 2022

Hey @ChristianEdwardPadilla, I'm happy to keep this channel updated with a list of packages completed, and the package that is currently being worked on so you guys can track progress.

Completed
Core
Analytics
App Check
Firestore
Auth
Database
Messaging
Performance
Remote Config
Storage
Functions

In Progress

To Be Completed

We're happy for you to help if you wish 😄. You just need to branch off v9/core branch, select a package to be completed, and update this channel/open draft PR 👍

@m6keller
Copy link

Has V9 support been added to the main FlutterFire branch? I am trying to implement it in a Flutter project and was wondering if there has been any documentation added for using V9 modular imports for a Flutter project. Thanks!

@russellwheatley
Copy link
Member

@m6keller We have all the PRs in review. Once they're approved, we'll merge into v9/core branch and test them all together. It won't be part of the main release just yet, but it will be available for users to test out.

@m6keller
Copy link

@russellwheatley Ok, thanks!

@ChristianEdwardPadilla
Copy link
Contributor

Seems this is done or obsolete since #8235? Great work!

@russellwheatley
Copy link
Member

Yes, we've decided to make it part of the normal release cycle considering our CI was passing, and it was the underlying implementation that had changed, not the user facing API. Except for auth and messaging which have breaking changes and will both have a major version change.

@russellwheatley
Copy link
Member

Hey @ChristianEdwardPadilla, just to let you know. Web v9 JS SDK has now been released across all relevant plugins which you can see on the CHANGELOG.md.

@jschaider
Copy link

jschaider commented Jul 18, 2022

@russellwheatley Wanting to followup on this thread. I am wondering how the flutter web plugins can pick up the js defined functions for interop? The ES6 exports symbol exports the js to other js files that import it but doesn't define them on window for the flutter web plugin to interop with correct?

@jschaider
Copy link

Answered my own question! the *-compat.js Firebase files handle exporting on window :)

@firebase firebase locked and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: web Issues / PRs which are specifically for web.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants