Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): automatically inject Firebase JS SDKs #7359

Merged
merged 49 commits into from Dec 2, 2021
Merged

Conversation

Ehesp
Copy link
Member

@Ehesp Ehesp commented Nov 12, 2021

Description

Automatically register plugins on web and inject scripts. See #7358 for more information.

@google-cla google-cla bot added the cla: yes label Nov 12, 2021
@github-actions
Copy link

github-actions bot commented Nov 12, 2021

Visit the preview URL for this PR (updated for commit 9c2cf62):

https://flutter-firebase-docs--pr7359-ehesp-auto-init-web-emhr02ug.web.app

(expires Thu, 09 Dec 2021 15:58:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@creativecreatorormaybenot
Copy link
Contributor

That is a super cool feature @Ehesp 🔥 Thanks for the great work 💪

A small request: could you please consider #7365? Would be great to get your input on that.

Copy link
Contributor

@creativecreatorormaybenot creativecreatorormaybenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @Ehesp 🙏

@Ehesp Ehesp marked this pull request as ready for review December 2, 2021 10:47
@Salakar Salakar changed the title feat: automatically inject Firebase JS SDKs feat(web): automatically inject Firebase JS SDKs Dec 2, 2021
@Salakar Salakar merged commit 5f4c414 into master Dec 2, 2021
@Salakar Salakar deleted the @ehesp/auto-init-web branch December 2, 2021 16:23
pr-Mais pushed a commit that referenced this pull request Dec 4, 2021
Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
@firebase firebase locked and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants