Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_crashlytics): Set the dSYM file format through the Crashlytic's podspec to allow symbolicating crash reports. #7872

Merged
merged 1 commit into from Jan 18, 2022

Conversation

elenadoty
Copy link
Contributor

@elenadoty elenadoty commented Jan 14, 2022

Description

Adds a pubspec flag to set the dSYM file format for all iOS build modes to DWARF with dSYM file. See this flutter issue for additional context.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title feat(firebase_crashlytics): set dsym format through podspec feat(firebase_crashlytics): Set the dSYM file format through the Crashlytic's podspec to allow symbolicating crash reports. Jan 18, 2022
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salakar Salakar merged commit d5d7e26 into master Jan 18, 2022
@Salakar Salakar deleted the podspec-injection branch January 18, 2022 09:41
@firebase firebase locked and limited conversation to collaborators Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants