Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: recreate ios, android, web and macOS folders for example app #8255

Merged
merged 2 commits into from Mar 29, 2022

Conversation

pr-Mais
Copy link
Member

@pr-Mais pr-Mais commented Mar 10, 2022

Description

Running flutter create . to generate the new files for ios, android, macos and web.

Related Issues

closes #7468

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Salakar Salakar changed the title feat(firestore): recreate ios, android, web and macOS folders for example app refactor(firestore): recreate ios, android, web and macOS folders for example app Mar 29, 2022
@Salakar Salakar changed the title refactor(firestore): recreate ios, android, web and macOS folders for example app refactor: recreate ios, android, web and macOS folders for example app Mar 29, 2022
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salakar Salakar merged commit cdae061 into master Mar 29, 2022
@Salakar Salakar deleted the @mais/firestore-example branch March 29, 2022 14:44
@firebase firebase locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore][documentation] Example macOS Podfile is not up-to-date
3 participants