Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android,core): allow initializing default Firebase apps via FirebaseOptions.fromResource on Android #8566

Merged
merged 1 commit into from May 3, 2022

Conversation

Salakar
Copy link
Member

@Salakar Salakar commented May 3, 2022

Description

Supersedes #8535 . Additionally updated example app to support initializing a default app from Android resources.

Files that should be reviewed can be seen here: https://github.com/firebase/flutterfire/pull/8566/files?file-filters%5B%5D=.dart&file-filters%5B%5D=.java&show-deleted-files=false&show-viewed-files=false (there are other changes since I had to update the Android project for latest Flutter SDK changes)

Logs from local testing showing this is working:

I/flutter (15634): Currently initialized apps: []
I/flutter (15634): Initialized default app FirebaseApp([DEFAULT]) from Android resource
I/flutter (15634): Currently initialized apps: [FirebaseApp([DEFAULT])]
I/flutter (15634): Current options for app [DEFAULT]: {apiKey: xxxxxxxxx, appId: 1:406099696497:android:0d4ed619c031c0ac3574d0, messagingSenderId: 406099696497, projectId: flutterfire-e2e-tests, authDomain: null, databaseURL: https://flutterfire-e2e-tests-default-rtdb.europe-west1.firebasedatabase.app, storageBucket: flutterfire-e2e-tests.appspot.com, measurementId: null, trackingId: null, deepLinkURLScheme: null, androidClientId: null, iosClientId: null, iosBundleId: null, appGroupId: null}

image

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@google-cla

This comment was marked as outdated.

@Salakar Salakar force-pushed the fix/init-options-from-resource branch from 3e644b5 to 4f666f6 Compare May 3, 2022 10:22
@Salakar Salakar changed the title feat(android,core): allow initializing default Firebase apps via FirebaseOptions.fromResource Android method feat(android,core): allow initializing default Firebase apps via FirebaseOptions.fromResource on Android May 3, 2022
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Salakar Salakar merged commit 30216c4 into master May 3, 2022
@Salakar Salakar deleted the fix/init-options-from-resource branch May 3, 2022 10:59
@firebase firebase locked and limited conversation to collaborators Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants