Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate from hash* to Object.hash* #8797

Merged
merged 3 commits into from Jun 1, 2022

Conversation

werainkhatri
Copy link
Contributor

Description

Migrates to Object.hash and Object.hashAll from hashValues and hashList respectively. This removes the dependency to flutter/widgets or flutter/material.dart from a few plugins.

Related Issues

flutter/flutter#85431

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@werainkhatri werainkhatri changed the title migrate: hash* (from dart:ui) to Object.hash* refactor: migrate from hash* to Object.hash* May 29, 2022
Copy link
Contributor

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to remove the version increment and the notes in the changelog, because they are generated via Melos:

We push releases manually, using Melos to take care of the hard work.

Changelogs and version updates are automatically updated by a project maintainer (via Melos). The new version is automatically generated via the commit types and changelogs via the commit messages.

https://github.com/firebase/flutterfire/blob/master/CONTRIBUTING.md#the-release-process

@nilsreichardt
Copy link
Contributor

You can just run git revert 7ce478aaf64befa878fd3e11ce2c4d5d14788300 👍

@werainkhatri
Copy link
Contributor Author

I think you need to remove the version increment and the notes in the changelog, because they are generated via Melos:

oh that's neat, reverting...

@russellwheatley russellwheatley merged commit 3dfc099 into firebase:master Jun 1, 2022
@werainkhatri werainkhatri deleted the migrate-hash branch June 1, 2022 12:38
@firebase firebase locked and limited conversation to collaborators Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants